-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authority utils assembly #5074
base: master
Are you sure you want to change the base?
Authority utils assembly #5074
Conversation
|
Hello @RenanSouza2 and than you for this PR. We will consider the idea, but we may implement it using a library for low level that we have in the pipeline. |
immediate = abi.decode(data, (bool)); | ||
bytes memory data = abi.encodeCall(IAuthority.canCall, (caller, target, selector)); | ||
|
||
assembly { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assembly { | |
assembly ("memory-safe") { |
Cosidering the low level library is not really comming "soon", I think we should merge that in 5.3 |
Hey @Amxx, good to know About the low level library, is there anything I can do to help there? |
Last time we discussed it, we could not agree on what the right abstraction was. I'm not sure an external opinion is needed. Thank you for the proposal though |
This implements authority utils with assembly to improve gas and memory usage
This is comparisom created with the gas-reporter in the repository
PR Checklist