profile: add program memory segment usage analysis #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaokamikami
force-pushed
the
mem-analysis
branch
2 times, most recently
from
182c77d to
2a074ae
Compare
shinezyy
requested changes
Jan 29, 2024
Kconfig
Outdated
| @@ -308,6 +308,16 @@ config TIMER_CLOCK_GETTIME | |||
| bool "clock_gettime" | |||
| endchoice | |||
|
|
|||
| config PROGRAM_ANALYSIS | |||
There was a problem hiding this comment.
program analysis 这个词太宽泛了，建议改为 memory region analysis
src/memory/paddr.c
Outdated
| if (display_file == true) { | ||
| FILE* fp = fopen(any_mem_file,"wr"); | ||
| for (int i = 0; i < PROGRAM_ANALYSIS_PAGES; i++) { | ||
| if (mem_addr_ues[i]) { |
There was a problem hiding this comment.
mem_addr_ues -> mem_addr_use
src/memory/paddr.c
Outdated
| if (mem_addr_ues[i]) { | ||
| char result[32]; | ||
| if (display_file) { | ||
| sprintf(result,"%d\n",i); |
There was a problem hiding this comment.
逗号后面应该有空格：
sprintf(result, "%d\n",i);
src/monitor/monitor.c
Outdated
| case 'A': | ||
| #ifdef CONFIG_PROGRAM_ANALYSIS | ||
| Log("Set mem analysis log path %s",optarg); | ||
| any_mem_file = optarg; |
There was a problem hiding this comment.
any_mem_file 这个名字太奇怪了，建议改为 memory_region_record_file
src/monitor/monitor.c
Outdated
| @@ -247,6 +256,7 @@ static inline int parse_args(int argc, char *argv[]) { | |||
|
|
|||
| printf("\t--simpoint-profile simpoint profiling\n"); | |||
| printf("\t--dont-skip-boot profiling/checkpoint immediately after boot\n"); | |||
| printf("\t--analysis-mem-path result output file for analyzing the memory use segment\n"); | |||
There was a problem hiding this comment.
--analysis-mem-path 建议改为 memory_region_record_file 类似的词汇
xiaokamikami
force-pushed
the
mem-analysis
branch
from
2a074ae to
d525258
Compare
|
修改好了 |
xiaokamikami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MEMORY_REGION_ANALYSISis configured, the program's memory segment usage analysis is started and printed or exported to a file. The path is set using --mem_use_record_file, and the analysis is performed in 32MB block units by default