fix(transcription): make self-hosted model configurable#1043
Open
xAlcahest wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In self-hosted mode the model was never configurable:
getTranscriptionModel()inaudioManager.jshas no self-hosted branch, so it resolved the model from leftover cloud provider settings and for a fresh setup always fell back togpt-4o-mini-transcribe, which most self-hosted servers reject withmodel_not_found. The self-hosted panel now has a Model field (stored asremoteTranscriptionModel) that is sent verbatim when set; left empty, everything behaves exactly as before.Tracing the same path also showed that
shouldUseStreaming()never checked self-hosted mode: a self-hosted user with a stored OpenAI key and the default realtime model was silently routed to OpenAI's realtime WebSocket instead of their own server. Self-hosted mode now always goes through batch HTTP to the configured URL.Fixes #1013
Changes