fix(linux): stop overlay focus theft on wlroots (Sway)#1026
Open
sochotnicky wants to merge 1 commit into
Open
Conversation
…on type On wlroots compositors the dictation/preview/notification overlays steal focus on map. Root cause: the overlays are created focusable:false, which makes Electron map them as override-redirect XWayland windows. wlroots' XWayland focuses override-redirect windows on map unless their _NET_WM_WINDOW_TYPE is in its no-focus set (notification/tooltip/utility/splash/menus) — and the overlays are TOOLBAR/NORMAL, which are not. Mutter/KWin honor focusable:false directly, so GNOME/KDE never had the bug; forcing XWayland (the prior fix) doesn't help here because it's already XWayland. Map the non-interactive overlays (dictation mic, transcription preview, meeting notification) as type "notification" on wlroots, which is in wlroots' no-focus set — clicks still work, keyboard focus isn't grabbed. GNOME/KDE keep their existing types (no regression). The agent overlay is left focus-capable since it needs keyboard input for chat. Verified against xprop on Sway: preview was override-redirect + TOOLBAR (focus stolen); no_focus rules and get_tree don't apply to override-redirect windows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wlroots compositors the dictation/preview/notification overlays steal focus on map. Root cause: the overlays are created focusable:false, which makes Electron map them as override-redirect XWayland windows. wlroots' XWayland focuses override-redirect windows on map unless their _NET_WM_WINDOW_TYPE is in its no-focus set (notification/tooltip/utility/splash/menus) — and the overlays are TOOLBAR/NORMAL, which are not. Mutter/KWin honor focusable:false directly, so GNOME/KDE never had the bug; forcing XWayland (the prior fix) doesn't help here because it's already XWayland.
Map the non-interactive overlays (dictation mic, transcription preview, meeting notification) as type "notification" on wlroots, which is in wlroots' no-focus set — clicks still work, keyboard focus isn't grabbed. GNOME/KDE keep their existing types (no regression). The agent overlay is left focus-capable since it needs keyboard input for chat.
Verified against xprop on Sway: preview was override-redirect + TOOLBAR (focus stolen); no_focus rules and get_tree don't apply to override-redirect windows.
Fixes the focus stealing on Sway for me at least and should fix #719