fix: crash on first "Install & Restart" click after an update#1012
Merged
gabrielste1n merged 2 commits intoJul 3, 2026
Conversation
… app.emit("before-quit")
The manual app.emit("before-quit) passed no Event object, causing
event.preventDefault() to throw TypeError; the second click worked only
because the crash left isShuttingDown = true, causing an accidental
early-return.
Use autoUpdater's before-quit-for-update event for pre-quit cleanup.
…toUpdater
electron-updater emits this event on require("electron").autoUpdater (and
Squirrel.Mac emits it there natively before closing windows), not on its own
instance, so the previous listener never fired. Without it, macOS installs
stalled: windowManager.isQuitting stayed false, the control panel prevented
close and hid to tray, and Squirrel waited on window-all-closed forever.
Also shut down sidecars best-effort on the update quit path and drop the
unreachable globalShortcut fallback (hotkeyManager is always set).
gabrielste1n
force-pushed
the
fix-auto-update-install-failing
branch
from
da856ab to
b2d51fb
Compare
Collaborator
|
thank you legend @IdrisGit !! |
gabrielste1n
approved these changes
Jul 3, 2026
gabrielste1n
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installUpdate()calledapp.emit("before-quit")with no Event argument, causingevent.preventDefault()to throw TypeError in theapp.on("before-quit")listener.Instead of doing manual teardown and relying on the
removeAllListenersworkaround, it's now using Electron's dedicated before-quit-for-update event for pre-quit cleanup, and make thebefore-quitlistener update-aware soquitAndInstall()can proceed withoutpreventDefault()blocking it.Here are the compressed trace logs of the error
fixes #1006