add nodeselector/affinity/tolerations/capabilities to separate r10k deployment#10
Open
ke5C2Fin wants to merge 7 commits intoOpenVoxProject:mainfrom
Open
add nodeselector/affinity/tolerations/capabilities to separate r10k deployment#10ke5C2Fin wants to merge 7 commits intoOpenVoxProject:mainfrom
ke5C2Fin wants to merge 7 commits intoOpenVoxProject:mainfrom
Conversation
…ng, move puppetserver.masters to template like puppetserver.compilers
ke5C2Fin
requested review from
Xtigyro,
anthonysomerset and
davidphay
as code owners
Collaborator
|
this looks ok, please can you update the unit tests as needed, update the change long and bump the version number if you aren't already in the credits list at the bottom of readme then please do add yourself as a contributor thanks |
Contributor
Author
|
Can you tell me how I can test these tests? |
anthonysomerset
approved these changes
Mar 18, 2026
Collaborator
anthonysomerset
left a comment
anthonysomerset
left a comment
There was a problem hiding this comment.
i've effectively reverted your changelog edit as has been superseded by auto changelog generation but otherwise all good so lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add nodeselector/affinity/tolerations/capabilities to separate r10k deployment
fix | (pipe) spacing
move puppetserver.masters.affinity to template like puppetserver.compilers.affinity