Skip to content

Conversation

@JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 4, 2025

related PRs

Summary by CodeRabbit

Release Notes

  • New Features
    • Added optional double-check verification for wake-word activations with configurable thresholds to enhance recognition accuracy.
    • Integrated voice activity detection (VAD) pre-check, ensuring wake-word detection only triggers when speech activity is detected.
    • New configuration options available to customize wake-word verification behavior and sensitivity settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Walkthrough

Configuration file updated to add wake-word verification settings and a VAD pre-wake check flag. A new "ww_verifiers" section introduces optional verification logic using "ovos-ww-verifier-silero" with configurable thresholds, while "vad_pre_wake_enabled" ties wake-word checks to VAD activity detection.

Changes

Cohort / File(s) Summary
Configuration updates
ovos_config/mycroft.conf
Added "ww_verifiers" section with "ovos-ww-verifier-silero" verifier configuration (threshold and enabled flag set to false). Added "vad_pre_wake_enabled" flag (set to true). Removed placeholder comment about VAD speech-end detection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Configuration-only changes with no code logic modifications
  • Changes are additive and straightforward flag/setting declarations
  • No interdependencies or complex logic introduced

Poem

🐰 A config fix, light and clean,
Wake-words verified, calm and keen,
With VAD's gentle listening ear,
False alarms just disappear! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'enable pre-wake-vad by default' accurately reflects the main change: introducing vad_pre_wake_enabled flag set to true in the configuration.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prewakevad

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68f4075 and ce29d1c.

📒 Files selected for processing (1)
  • ovos_config/mycroft.conf (1 hunks)
🔇 Additional comments (2)
ovos_config/mycroft.conf (2)

432-440: LGTM - Wake word verifier infrastructure with clear rationale.

The wake word verifier configuration is well-structured with an appropriate comment explaining why it's disabled by default when vad_pre_wake_enabled is true. The disabled state avoids redundant verification layers while preserving the configuration for users who may want different setups.


442-444: Config addition is appropriate but clearly document this as a breaking change.

This is a configuration-only package; the actual vad_pre_wake_enabled feature implementation exists downstream in ovos-core. The VAD fallback behavior is already documented in the config (lines 476-486): if a VAD plugin is unavailable, it falls back to RATIO_ONLY.

However, enabling this by default is a behavioral change that affects existing installations. Ensure:

  1. Release notes clearly document this default behavior change and its implications
  2. Users understand that this gates wake-word detection behind VAD speech detection
  3. Downstream testing in ovos-core validates false negative rates and VAD plugin fallback chains

The configuration is well-documented; focus on communicating the breaking change to users.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OpenVoiceOS OpenVoiceOS deleted a comment from codecov-commenter Nov 4, 2025
@JarbasAl JarbasAl merged commit 8cfb043 into dev Nov 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants