First PR for new LED gpio rewrite back to BaseMain #1514
+9,412
−6,329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chase and static animations now done
Verified move types. Added new allowance for 1 missing input in middle sized roll moves
Added Knight rider effect and changed button colours to be indexed from preset colours to save config space
Added priority so special moves with more inputs but similar to other moves can be prioritised (eg EX moves). Added new Jiggle effect to simulate fire/electricity.
Removed old led config stuff to save space. Added new OFF state for LED profiles. Fixed lcd screen to not show blank bar on boot and to cope with Off state for LED profiles
Added get and set for AnimationProtoOptions to write and read the various settings for webconfig editing
Brightness is now 1-10 for all boards. Removed redundant data from web api. LED profile now correctly saved if set to OFF
…d12/GP2040-CE into LED_ConvertToGIPOWithNewAnimations # Conflicts: # src/animationstation/animationstation.cpp # src/webconfig.cpp
Added missing defines for Frame max. Fixes for led timeout and case led colour selection
# Conflicts: # www/src/Locales/ko-KR/Index.jsx # www/src/Locales/zh-CN/Index.jsx # www/src/Locales/zh-CN/LedConfig.jsx # www/src/Pages/LEDConfigPage.jsx
Set brightness max to be 0-100 on webconfig
Led convert to gipo with new animations
Led convert to gipo with new animations
Led convert to gipo with new animations
Led convert to gipo with new animations
|
Thanks for submitting the PR @Podbod12 ! This will take quite a bit of time to review as its an extensive overhaul / code addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted LED system to use GPIO and rewrote all the animations. Adding new and more powerful ones. Full Rewrite of LED setup including webconfig side. Beginner mode gives easy setup for most users but Advanced mode allows per LED adjustments and accurate spacing for the best effects.