Feature/add sessionrecording extension#148
Conversation
Pre populate the playback file with the latest recorded file as well
|
Seeing how many people include the UI in their render sequences without intending to, I think it does count as a bug fix |
src/panels/SessionRecordingPanel/Record/RecordingStopButton.tsx
Outdated
Show resolved
Hide resolved
src/panels/SessionRecordingPanel/Record/RecordingStopButton.tsx
Outdated
Show resolved
Hide resolved
src/panels/SessionRecordingPanel/Record/RecordingStopButton.tsx
Outdated
Show resolved
Hide resolved
|
Uncheck hide gui by default |
WeirdRubberDuck
left a comment
There was a problem hiding this comment.
Had quite a few things to comment on here. See most of them in code
-
First, should we maybe hide the extension if the playback file dropdown? It gets much harder to read with all the file names ,and they do not really matter for playback

-
Do we really need both these checkboxes, or would it be sufficient with one checkbox that says "Hide all GUI elements on playback"? That would make the interface less cluttered, and if a user want to show the dashboard but not the UI I can imagine that they do not want to show all part of it and could go into the settings and hide the things they want anyways? Maybe worth discussing

src/panels/SessionRecordingPanel/Playback/PlaybackStopButton.tsx
Outdated
Show resolved
Hide resolved
src/panels/SessionRecordingPanel/Record/RecordingStopButton.tsx
Outdated
Show resolved
Hide resolved
src/panels/SessionRecordingPanel/Record/RecordingStopButton.tsx
Outdated
Show resolved
Hide resolved
| <Text mb={'xs'}> | ||
| Caution: Enabling both{' '} | ||
| <Text fs={'italic'} span inherit> | ||
| Loop playback | ||
| </Text>{' '} | ||
| and{' '} | ||
| <Text fs={'italic'} span inherit> | ||
| Hide GUI | ||
| </Text>{' '} | ||
| will cause the interface to remain hidden indefinitely during playback. To | ||
| reveal the GUI again, press: | ||
| </Text> |
There was a problem hiding this comment.
I see why this text string is needed, and like that the settings are marked in italics, but this text will be a pain to localize using i18next. Did we come up with a good way to deal with italics?
There was a problem hiding this comment.
Will see what the solution will be in the other PR that handles the translation
I see what you mean but since we allow the same name with different extension it will be super weird to see
I think we want both, I could see a situation where I want to show dashboards that could contain e.g., distance information but not show the rest of the GUI
I think the whole point for these settings is to make it easier to not have to maually do this every time you go playback / normal usage |
|
How about only showing the extensions if there is an ambiguity? In particular since users would be able to choose whicherever extension they like and not just |
Is this something that we've told users? Because now we specifically check for these extensions and force any new recordings to have these extensions depending on the format used |
|
Yea, you're right. I don't think we need to account for it. If they give it a wrong extension on purpose, we don't need to take care of it |

#fixes OpenSpace/OpenSpace#3670
Also select the latest recorded file in the playback dropdown
Fixed some additional issues with the error message so it should be somewhat smoother to use now
Also added option to hide GUI when playing back a session recording: #fixes OpenSpace/OpenSpace#3682 - This one might count as a new feature tho so question is if it should be included now? Can revert the last commit if so.