-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #8 #13
base: master
Are you sure you want to change the base?
Fix for Issue #8 #13
Conversation
arguments.py
Outdated
import argparse | ||
|
||
parser = argparse.ArgumentParser('SWE1R scripts ') | ||
parser.add_argument('--out', description='directory where the output files are written', default='/tmp/swep1r') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we will probably have a lot of windows users, I'd like to get rid of the "/tmp/" folder altogether.
It would be fine with me if it somehow chose the platforms temp folder or output to a subfolder of the current directory by default.
(the scripts also lack the ability to generate the output folder if it doesn't exist yet, but that's probably a seperate issue)
Thanks a lot for looking into it, I'll test and continue review later. (Also check-out the main project, which is a loader and re-implementation of the game) |
…tered directory if it doesnt exist
Yes, I stumbled upon that main project, I'll try it out as well ^^ |
Sorry for the delay on this one; I'm still unhappy with the quality to be honest. I started fixing this locally but got distracted with other things (hence the delay). I'll try to get back to this soon though. |
Stumbled upon this repo,
This should solve the issue #8 with the hardcoded paths, using argparse to parse incoming CLI arguments.
Didn't really test, don't have data files handy, but this should work