Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Skip to content' link for pages that are not the home page #222

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Fix 'Skip to content' link for pages that are not the home page #222

merged 1 commit into from
Jul 21, 2021

Conversation

kingdomlevel
Copy link
Contributor

Closes #172 by replacing the Skip To Content component's anchor tag with a <Link> from the react-router-dom package.

@adamgparsons adamgparsons changed the base branch from main to develop July 20, 2021 13:59
@adamgparsons adamgparsons marked this pull request as ready for review July 20, 2021 14:10
adamgparsons
adamgparsons approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@adamgparsons adamgparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Living the dream

@adamgparsons adamgparsons merged commit 2dcda83 into develop Jul 21, 2021
@kingdomlevel kingdomlevel deleted the fix/172-skip-to-content branch July 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgparsons adamgparsons adamgparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip to main content not functioning as expected
2 participants
@kingdomlevel @adamgparsons