ui-trackoccupancydiagram: select zone on click #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohh
force-pushed
the
usn/ui-trackoccupancydiagram-select-zone-onclick
branch
from
61310e5 to
54226f4
Compare
- setup mouseContext from spacetimechart - isolate TrackOccupancyDiagram to import it in a new story component - use selectedTrainId and setSelectedTrainId as props - add train selection on click in drawOccupationZone based on mouse position Co-authored-by: Yohh <[email protected]> Signed-off-by: Uriel-Sautron <[email protected]>
Yohh
force-pushed
the
usn/ui-trackoccupancydiagram-select-zone-onclick
branch
from
54226f4 to
49a9e79
Compare
Caracol3
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As precised in the main feature ticket the selected train is set by clicking on an occupation zone, we could add an enhancement in future for setting the selecting by clicking on the train name either, not done yet because of the complexity it brings.
The TrackOccupancyDiagram has been isolated to be called in a new story component, which will allow us to easily move it in ui-trackoccupancyDiagram if needed in another PR.
close #787