fix: one-way cards "frozen" order #663
Open
+53
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
Signed-off-by: Louis Greiner <[email protected]>
louisgreiner
force-pushed
the
lgr/fix-one-way-cards-order
branch
from
6d63cb0 to
8651629
Compare
aiAdrian
changed the title
Contributor
Author
|
The formatting issue is currently being dealt here: #673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
A slight refactor is also part of this PR, as well as a fix in Perlenkette and Streckengrafik components. See individual commits.
Description
Close #658
Close #671
Also fix the CI test of OpenRailAssociation/osrd#14113 (comment)
I also tested that the current behavior is still aligned with this new proposal.
You can test using this network graphic, switching all the trainruns from round trip to one-way: base.json
Both implementation result in this:
And the bug in this network graphic (mentionned above) is fixed. You can try with that: reticulaire(12).json
Issues
Checklist
documentation/