Fix some issues with OG tags for social sharing #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a jekyll plugin for SEO if we wanna take this to the next level but I think what this PR implements is good for this site's needs. |
|
Update: Add a commit that removes unnecessary Twitter tags (twitter picks up the info from the OG tags). |
|
Needs a rebase now. |
Twitter picks up the data form OG tags so there is no need to duplicate it.
dragunoff
force-pushed
the
feature/og-tags-extend
branch
from
d727ecc to
465932a
Compare
|
Update: rebased and fixed canonical href to be an absolute URL. |
abcdefg30
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages explain what I did here in detail but the basic idea is to print meta data for the current page instead of the same data for the whole site. This is a problem because if for example a news article is shared on FB it will display the title of the site and link to the homepage. This can be seen in the FB debugger:
I also fixed the social image by using an absolute url and I added a canonical meta tag (for SEO).
Depends on #16