Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix&updates #362

Closed
wants to merge 3 commits into from
Closed

Fix&updates #362

wants to merge 3 commits into from

Conversation

zapobyte
Copy link

@zapobyte zapobyte commented May 27, 2020

PR content:

  • upgraded dependencies as much as possible without broking the app(see requirements.txt)
  • fixes Improved Resource Center Search #360
  • refactored the html a bit(index.html)
  • fixed a bug in django where comments(/comments/ url) would break if no comments where detected in db
  • added font-awesome icons(https://fontawesome.com/)


Unfortunately i did a stupid thing, VS code python linter linted the whole code ... hope this is not a problem if so will revert and only add the current changes, please let me know.

@zapobyte zapobyte marked this pull request as draft May 27, 2020 11:16
@pchote
Copy link
Member

pchote commented May 27, 2020

Please do try to revert the VS style changes. I suspect that this is mainly just line endings, so i'm surprised that git's autocrlf feature didn't fix this automatically.

You should be able to use dos2unix (or its equivalent under windows) to fix this without restarting from scratch.

@zapobyte
Copy link
Author

zapobyte commented Jun 2, 2020

closing.changes included in #363

@zapobyte zapobyte closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Resource Center Search
2 participants