Skip to content

Add AnalogEmulatorDataGroup for analog emulator output - #11

Open
CodeMaverick2 wants to merge 1 commit into
OpenQuantumDesign:mainfrom
CodeMaverick2:feat/analog-emulator-data-group
Open

Add AnalogEmulatorDataGroup for analog emulator output#11
CodeMaverick2 wants to merge 1 commit into
OpenQuantumDesign:mainfrom
CodeMaverick2:feat/analog-emulator-data-group

Conversation

@CodeMaverick2

@CodeMaverick2 CodeMaverick2 commented May 22, 2026

Copy link
Copy Markdown

Summary

Adds AnalogEmulatorDataGroup - the shared HDF5 schema for classical analog emulator runs (unitaryHACK / oqd-analog-emulator #9).

Datasets: times, metrics (2D + metric_labels in attrs as JSON), state (2D trajectory), optional measurements.

Group attrs: run metadata (backend, dt, fock_cutoff, n_shots, etc.).

Why separate PR

Emulator backends should not define their own on-disk format. This group is registered in GroupRegistry and exported from oqd_dataschema.

Test plan

  • pytest tests/test_analog_emulator_group.py — registration + HDF5 round-trip
  • Full suite: 147 passed, 57 xfailed (unchanged from main)

Merge order

Merge this before oqd-analog-emulator #10.

Co-authored-by: Cursor <cursoragent@cursor.com>
@CodeMaverick2

Copy link
Copy Markdown
Author

@benjimaclellan Would love to know your thoughts on PR

@benjimaclellan benjimaclellan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! Data structure looks clean and everything seems good. I'll leave comments over in the analog-emulator repo for the rest of the issue.

@CodeMaverick2

Copy link
Copy Markdown
Author

@benjimaclellan ready for merge whenever you are.

Merge order:

  1. oqd-dataschema #11 first
  2. Then oqd-analog-emulator #10

Let me know if anything else needs tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants