Search updates #2146
Merged
Search updates #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify storage setup to re-use existing volumes.
Landingheader
107 feature flag
david-nishi
suggested changes
May 29, 2021
packages/openneuro-components/src/search-page/SearchResults.stories.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/SearchResults.stories.tsx
Outdated
Show resolved
Hide resolved
david-nishi
suggested changes
May 30, 2021
packages/openneuro-components/src/search-page/KeywordInputContainer.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/FiltersBlockContainer.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/SearchPageContainer.tsx
Outdated
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/FacetBlockContainer.tsx
Outdated
Show resolved
Hide resolved
david-nishi
suggested changes
May 30, 2021
packages/openneuro-components/src/mock-content/facet-content.jsx
Outdated
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/KeywordInputContainerExample.tsx
Outdated
Show resolved
Hide resolved
david-nishi
suggested changes
May 30, 2021
packages/openneuro-components/src/search-page/SearchPageContainerExample.tsx
Show resolved
Hide resolved
packages/openneuro-components/src/search-page/SearchPageContainerExample.tsx
Outdated
Show resolved
Hide resolved
david-nishi
suggested changes
May 31, 2021
There was a problem hiding this comment.
Changes are looking good! Two more things to do and I think that will wrap up the ci issues:
showDatasetsRadioimported in /Radio.stories.tsx does not exist in /facet-content.jsx.activeandsetActiveneed to be updated to "selected" in in /Radio.stories.tsx.
david-nishi
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.