Skip to content

fix: preserve saved subtitle style when rendering#4

Open
z2z23n0 wants to merge 1 commit into
OpenMOSS:mainfrom
z2z23n0:fix/preserve-saved-subtitle-style
Open

fix: preserve saved subtitle style when rendering#4
z2z23n0 wants to merge 1 commit into
OpenMOSS:mainfrom
z2z23n0:fix/preserve-saved-subtitle-style

Conversation

@z2z23n0

@z2z23n0 z2z23n0 commented Jul 10, 2026

Copy link
Copy Markdown

Problem

Subtitle style updates are persisted on the job, but rendering without a request body rebuilt SubtitleStyle from None. That silently restored default font size, margin, and speaker names instead of using the saved style.

Fix

  • Reuse job.subtitle_style when the render request omits a style payload.
  • Preserve the existing behavior where an explicit render payload overrides the saved style.
  • Add an API regression test for both paths.

Tests

  • python -m pytest -q tests/test_app_api.py (4 passed)
  • python -m pytest -q (28 passed)

@z2z23n0 z2z23n0 marked this pull request as ready for review July 10, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant