Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture ignition/led-studio-par-platinum-20x3w-pwm #4520

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture ignition/led-studio-par-platinum-20x3w-pwm

Thank you ju_hnny5!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 1, 2025
Copy link

github-actions bot commented Jan 1, 2025

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ ignition / led-studio-par-platinum-20x3w-pwm: d-light / attributes-correctness
  • ✔️ ignition/led-studio-par-platinum-20x3w-pwm-5.xml
✔️ ignition / led-studio-par-platinum-20x3w-pwm: dmxcontrol3 / channel-numbers
  • ✔️ ignition-led-studio-par-platinum-20x3w-pwm-5.xml
✔️ ignition / led-studio-par-platinum-20x3w-pwm: dragonframe / json-schema-conformity
  • ✔️ ignition/led-studio-par-platinum-20x3w-pwm.json
  • ✔️ manufacturers.json
✔️ ignition / led-studio-par-platinum-20x3w-pwm: millumin / json-schema-conformity
  • ✔️ ignition/led-studio-par-platinum-20x3w-pwm.json
ignition / led-studio-par-platinum-20x3w-pwm: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Ignition-LED-Studio-Par-Platinum-20x3W-PWM.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected ./manufacturer/fixture.qxf: Invalid power consumption 1 definitions processed. 2 errors detected
ignition / led-studio-par-platinum-20x3w-pwm: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Ignition-LED-Studio-Par-Platinum-20x3W-PWM.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

"comment": "created by Q Light Controller Plus (version 4.13.1)"
}
},
"physical": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"physical": {
"links": {
"manual": [
"https://www.manualslib.com/manual/731621/Ignition-Led-Studio-Par-Platinum.html"
]
},
"physical": {

Comment on lines +41 to +48
"defaultValue": 0,
"capability": {
"type": "ShutterStrobe",
"shutterEffect": "Strobe",
"speedStart": "slow",
"speedEnd": "fast",
"helpWanted": "At which DMX values is strobe disabled?"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"defaultValue": 0,
"capability": {
"type": "ShutterStrobe",
"shutterEffect": "Strobe",
"speedStart": "slow",
"speedEnd": "fast",
"helpWanted": "At which DMX values is strobe disabled?"
}
"capabilities": [
{
"dmxRange": [0, 15],
"type": "ShutterStrobe",
"shutterEffect": "Open"
},
{
"dmxRange": [16, 255],
"type": "ShutterStrobe",
"shutterEffect": "Strobe",
"speedStart": "slow",
"speedEnd": "fast"
}
]

},
"modes": [
{
"name": "5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "5",
"name": "6-channel",
"shortName": "MODE 5",

Comment on lines +57 to +60
"defaultValue": 0,
"capability": {
"type": "Intensity"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"defaultValue": 0,
"capability": {
"type": "Intensity"
}
"capabilities": [
{
"dmxRange": [0, 31],
"type": "NoFunction"
},
{
"dmxRange": [32, 63],
"type": "ShutterStrobe",
"shutterEffect": "RampUp"
},
{
"dmxRange": [64, 95],
"type": "ShutterStrobe",
"shutterEffect": "RampDown"
},
{
"dmxRange": [96, 127],
"type": "ShutterStrobe",
"shutterEffect": "RampUpDown"
},
{
"dmxRange": [128, 159],
"type": "Effect",
"effectName": "Automatic color chase"
},
{
"dmxRange": [160, 191],
"type": "Effect",
"effectName": "Coincidence color chase, 3 colors"
},
{
"dmxRange": [192, 223],
"type": "Effect",
"effectName": "Coincidence color chase, 7 colors"
},
{
"dmxRange": [224, 255],
"type": "Effect",
"effectName": "Start music control",
"soundControlled": true
}
]

}
}
},
"modes": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"modes": [
"modes": [
{
"name": "1-channel",
"shortName": "MODE 1",
"channels": [
"Color Macros"
]
},
{
"name": "2-channel",
"shortName": "MODE 2",
"channels": [
"Color Macros",
"Dimmer"
]
},
{
"name": "3-channel",
"shortName": "MODE 3",
"channels": [
"Red",
"Green",
"Blue"
]
},
{
"name": "5-channel",
"shortName": "MODE 4",
"channels": [
"Red",
"Green",
"Blue",
"Strobe",
"Dimmer"
]
},

"type": "ColorIntensity",
"color": "Blue"
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
},
"Color Macros": {
"capability": {
"type": "ColorPreset",
"helpWanted": "What colors at what values?"
}
},

"Dimmer",
"Special"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},
{
"name": "7-channel",
"shortName": "MODE 6",
"channels": [
"Red",
"Green",
"Blue",
"Color Macros",
"Strobe",
"Special",
"Dimmer"
]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants