-
Notifications
You must be signed in to change notification settings - Fork 37
Fix wrong server path for file upload endpoint #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@OpenHands review diff for this PR and help me create a new test based on this fix in tests/cross/test_remote_conversation_live_server.py |
|
I'm on it! xingyaoww can track my progress at all-hands.dev |
This test validates that the file upload fix works correctly end-to-end
by uploading a file through the RemoteWorkspace and verifying it arrives
at the correct location with the correct content.
This is a regression test for the file upload issue where the client was
calling /api/file/upload (without the path parameter) instead of
/api/file/upload/{path} as the server expects.
Co-authored-by: openhands <[email protected]>
SummaryI've successfully reviewed the PR diff and created a new integration test for the file upload fix in PR Fix OverviewThe PR fixed a mismatch between the client and server endpoints:
New Test CreatedAdded
The test follows the same pattern as the existing Changes Committed and Pushed✅ Test passes successfully The new test serves as a regression test to ensure the file upload endpoint URL fix continues to work correctly. |
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This PR fixed a mismatch between remote workspace and server implementation, which causes file uploading issue when running GAIA:
https://github.com/OpenHands/agent-sdk/blob/99051464f319baa7e6ba4ed03acad9500a2bb465/openhands-agent-server/openhands/agent_server/file_router.py#L30-L31
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
golang:1.21-bookwormeclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22Pull (multi-arch manifest)
Run
All tags pushed for this build
The
54b3637tag is a multi-arch manifest (amd64/arm64); your client pulls the right arch automatically.