Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Update option for addAnnotation. #1161

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

manthey
Copy link
Contributor

@manthey manthey commented Jan 27, 2022

Add an option to skip updating the layer when adding an annotation.

Add an option to skip updating the layer when adding an annotation.
@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for opengeoscience-geojs ready!

🔨 Explore the source changes: 8b3fdda

🔍 Inspect the deploy log: https://app.netlify.com/sites/opengeoscience-geojs/deploys/61f2b028573aa500077f7de6

😎 Browse the preview: https://deploy-preview-1161--opengeoscience-geojs.netlify.app

@manthey
Copy link
Contributor Author

manthey commented Jan 27, 2022

@boucaud This is a fairly simple change, so I'm happy to merge it once CI has passed.

@boucaud
Copy link

boucaud commented Jan 27, 2022

Thank you David !

Could we do the same thing for removeAnnotation() ?

@manthey
Copy link
Contributor Author

manthey commented Jan 27, 2022

Could we do the same thing for removeAnnotation() ?

Oddly, we already had that flag on removeAnnotation.

@boucaud
Copy link

boucaud commented Jan 27, 2022

Oddly, we already had that flag on removeAnnotation.

Oh that's true, I just assumed it was the same

@manthey manthey merged commit 4c7a526 into master Jan 27, 2022
@manthey manthey deleted the optional-add-annotation-update branch January 27, 2022 15:05
@github-actions
Copy link

🎉 This PR is included in version 1.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants