Repository navigation
pdfshift: Update HttpState data property docs - #1352
Merged
Merged
Conversation
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
| * @property data - the parsed response body | ||
| * @property response - the response from the HTTP server, including headers, statusCode, body, etc | ||
| * @property references - an array of all previous data objects used in the Job | ||
| * @property data - The parsed response body when `filename` is provided, otherwise a base64-encoded string. |
Collaborator
There was a problem hiding this comment.
I think this needs to go just on the generatePDF docs - not the general state docs. Because it doesn't really make sense on the generic request helper
Collaborator
There was a problem hiding this comment.
No, here. Do it on the function as an override
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
josephjclark
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
HttpStatedata property docsFixes #1343
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.