Repository navigation
kobotoolbox: Update http.request body description
#1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d0933c
fix: change `body` to `data` for http.request
hunterachieng df258c5
feat: add changeset
hunterachieng 25de33b
fix: update changeset
hunterachieng e8942c4
fix: update changeset
hunterachieng 4f0de4b
feat: add migration guide
hunterachieng 4597184
update changeset to patch
hunterachieng ad16368
fix: remove migration guide
hunterachieng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| --- | ||
| '@openfn/language-kobotoolbox': patch | ||
| --- | ||
|
|
||
| Update `http.request` option docs to use `data` instead of `body` in requests | ||
|
|
||
|
|
||
| ### Migration Guide | ||
|
hunterachieng marked this conversation as resolved.
Outdated
|
||
| - The `http.request()` function now uses `data` in stead of `body` for the body data. | ||
|
|
||
| #### Before | ||
|
|
||
| ``` | ||
| http.request('PATCH', `assets/aDReHdA7UuNBYsiCXQBr43/data/bulk/`, { | ||
| body: { | ||
| submission_ids: ['aDReHdA7UuNBYsiCXQBr43'], | ||
| data: { | ||
| Transaction_status: 'success', | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| ``` | ||
|
|
||
| #### Now | ||
|
|
||
| ``` | ||
| http.request('PATCH', `assets/aDReHdA7UuNBYsiCXQBr43/data/bulk/`, { | ||
| data: { | ||
| submission_ids: ['aDReHdA7UuNBYsiCXQBr43'], | ||
| data: { | ||
| Transaction_status: 'success', | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| ``` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.