Skip to content

Add bulk1 functions in salesforce - #1344

Merged
josephjclark merged 14 commits into
release/nextfrom
1305-bulk1
Aug 30, 2025
Merged

josephjclark merged 14 commits into
release/nextfrom
1305-bulk1

Conversation

@mtuchi

@mtuchi mtuchi commented Aug 25, 2025 •

Copy link
Copy Markdown
Collaborator

Summary

This PR adds bulk1 functions and remove bulk and bulkQuery function in salesforce adaptor

Fixes #1305

Details

  • Add bulk1 functions [query, upsert, destroy, update, and insert]
  • Add integration tests for bulk1 functions
  • Removed bulk and bulkQuery functions
  • Add migration guide for bulk and bulkQuery to use bulk1 and bulk2 instead
  • Add 1 unit test for bulk1 function. Mocking is really hard 😬

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • NA: If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@mtuchi mtuchi linked an issue Aug 25, 2025 that may be closed by this pull request
@mtuchi
mtuchi requested a review from hunterachieng August 25, 2025 16:54
Comment thread packages/salesforce/src/bulk1.js
@mtuchi
mtuchi requested a review from josephjclark August 28, 2025 10:33
@josephjclark

Copy link
Copy Markdown
Collaborator

@mtuchi as part of this release should we remove bulk and bulkquery from the main API? Otherwise we have three "bulk query" functions and it's all a bit confusing

Quite happy to bump this to a major release

@mtuchi

mtuchi commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator Author

@mtuchi as part of this release should we remove bulk and bulkquery from the main API? Otherwise we have three "bulk query" functions and it's all a bit confusing

Quite happy to bump this to a major release

Let me do that, i think it's a good idea to major version bump

@mtuchi

mtuchi commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator Author

Hiya @josephjclark i have removed bulk and bulkQuery. Please have a look

@josephjclark
josephjclark changed the base branch from main to release/next August 29, 2025 16:02
@josephjclark
josephjclark merged commit 919544d into release/next Aug 30, 2025
2 checks passed
@josephjclark
josephjclark deleted the 1305-bulk1 branch August 30, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Add bulk1 function in salesforce

4 participants