Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group-IB] Update Group-IB connector #3204

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kchekh
Copy link

@Kchekh Kchekh commented Dec 30, 2024

Proposed changes

Change storage and change seqUpdate parameter in state OpenCTI
Global separation of environment parameters and config.yml to run locally or in docker
Small code edits

Related issues

Checklist

  • I tested the code for its functionality using different use cases
  • I consider the submitted work as finished
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I have made some changes to the code of our integration and would like to introduce them a bit.
The first thing that was done was to split the configs into config,yml to bring up the connector locally and .env file to run in Docker.
https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/config.yml.sample
https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/.env.sample
Since the formats of these files are different and our configuration has a lot of moment variables for the collection, we implemented a solution for automated collection in the file https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/config.py.
The work with SeqUpdate storage for our API was completely moved to OpenCTI state and at the moment SeqUpdate does not appear in environment variables or config.yml file, all work with it is done in https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/lib/external_import.py file and with the help of state.
I ask you to check mentioned and other changes I’ve made, there are now in my repository: https://github.com/Kchekh/connectors/tree/update/external-import/group-ib

@nino-filigran nino-filigran added the community use to identify PR from community label Jan 3, 2025
@helene-nguyen helene-nguyen added partner used to identify PR from patner and removed community use to identify PR from community labels Jan 6, 2025
@yassine-ouaamou yassine-ouaamou changed the title Update Group-IB connector [Group-IB] Update Group-IB connector Jan 6, 2025
@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
@helene-nguyen
Copy link
Member

@Kchekh Thank you for the updated changes! We will have a review on this. Could you just sign your commits as it is required for merging the PR?

@Kchekh
Copy link
Author

Kchekh commented Jan 14, 2025

Hello @helene-nguyen,
Thank you for the information! Just to clarify, do you mean signing the commits using a GPG key?

@helene-nguyen helene-nguyen self-assigned this Jan 17, 2025
@helene-nguyen
Copy link
Member

@Kchekh Yes, sorry if it wasn't clear, it's signing with GPG key all the commits :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner used to identify PR from patner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants