Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilianian/abuse ssl/remove unused variable #3203

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Brazilianian
Copy link

Proposed changes

Just remove the variable to avoid confusion
Also filled doctrings to remove the warnigns

Related issues

#3194

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
@romain-filigran
Copy link
Member

Hello @Brazilianian : Thanks for your contribution.
In order to merge your PR, could you fix the problem with the lint verification ?
Capture d'écran 2025-01-03 120458

@Brazilianian
Copy link
Author

@romain-filigran Sure!

@romain-filigran
Copy link
Member

Checking the connector, it seems that the default CSV feed has been obsolete since the beginning of the year?
@Brazilianian : Do you have the same observation?

@Brazilianian
Copy link
Author

@romain-filigran

Yes, it looks like they closed both formats of ip feed:
.txt - Last updated: 2025-01-02 01:09:06 UTC
.csv - Last updated: 2025-01-03 11:30:00 UTC

I didnt find any articles or posts in social media about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants