Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove need for external API for whois lookups #3155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lissy93
Copy link

@Lissy93 Lissy93 commented Dec 18, 2024

Hiya,

This is a curtesy PR as I'm going to be implementing auth into who-dat.as93.net (the WHOIS API that you are using here), as in the last 2 months, your application has been sending a LOT of traffic my way, and I've unfortunately ended up with a pretty big compute bill.

In the future, I recommend that if you want to use mine or another devs hosted services commercially or publicly, it would help if you could let them know in advance, so they can pre-emptively ensure it scales efficiently and affordably. Because this has slightly ruined my Christmas!

P.s this PR is just a concept, you might want to edit it to better meet your users needs. Or let me know if you'd like me to make any changes or help with anything.

Cheers,
Alicia


Proposed changes

  • Remove external call to whois api (who-dat.as93.net)

Related issues

  • (I didn't open one yet - i can if u want me to?)

Checklist

  • [❌] I consider the submitted work as finished
  • [❌] I tested the code for its functionality using different use cases
  • [❌] I added/update the relevant documentation (either on github or on notion)
  • [✅] Where necessary I refactored code to improve the overall quality

Further comments

^^ See above

@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants