Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eset] FIX: Add x_opencti_main_observable_type when missing from atomic indicators #3013

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[eset] FIX: Add x_opencti_main_observable_type when missing from atomic indicators #3013

merged 2 commits into from
Jan 9, 2025

Conversation

ckane
Copy link
Contributor

@ckane ckane commented Nov 21, 2024 •
edited by helene-nguyen
Loading

Proposed changes

In the ESET connector, if an atomic indicator comes in as a URL, Domain-Name, or IPv4 Address, the upstream STIX doesn't have the x_opencti_main_observable_type on it. It also doesn't automatically get set during ingest. So, in the case of supported indicator types, add it to the bundle before ingest.

Related issue

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@ckane ckane changed the title [eset] Add x_main_observable_type when missing from atomic indicators [eset] Add x_opencti_main_observable_type when missing from atomic indicators Nov 21, 2024
@ckane ckane changed the title [eset] Add x_opencti_main_observable_type when missing from atomic indicators [eset] FIX: Add x_opencti_main_observable_type when missing from atomic indicators Nov 22, 2024
@ckane ckane force-pushed the eset-fix-main-observable-type branch from 437b3bb to d31c052 Compare November 26, 2024 03:35
@ckane ckane force-pushed the eset-fix-main-observable-type branch from d31c052 to 9710582 Compare December 4, 2024 14:40
@helene-nguyen helene-nguyen added filigran team use to identify PR from the Filigran team community use to identify PR from community and removed filigran team use to identify PR from the Filigran team labels Dec 5, 2024
@ckane ckane force-pushed the eset-fix-main-observable-type branch 3 times, most recently from a8f5ce1 to ef15c8c Compare December 11, 2024 14:10
@ckane ckane force-pushed the eset-fix-main-observable-type branch from ef15c8c to b291d53 Compare December 12, 2024 04:09
@helene-nguyen helene-nguyen linked an issue Jan 9, 2025 that may be closed by this pull request
[eset] Add x_opencti_main_observable_type when missing from atomic indicators #3237
Closed
@helene-nguyen helene-nguyen self-assigned this Jan 9, 2025
@helene-nguyen helene-nguyen merged commit 4923d25 into OpenCTI-Platform:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
community use to identify PR from community improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[eset] Add x_opencti_main_observable_type when missing from atomic indicators
3 participants
@ckane @helene-nguyen @romain-filigran