fix(cpp-qt-client): add asJsonObject method to OAIEnum class (#19307) #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the need for this new method ? Also, you would need to re-generate the example if you want the PR to be merge. |
|
@MartinDelille This PR adds the missing asJsonObject method to the Enum class. When generating the schema for enums, the generated client code does not compile with my FastAPI schemas that use enums, as the client is expecting this method. The issue is also reported by another person here: #19307 I've generated and pushed the examples. |
MartinDelille
approved these changes
May 6, 2025
ReallyVirtual
force-pushed
the
fix-cpp-qt-enum-asjsonobject
branch
from
988e125 to
543675d
Compare
…qt-enum-asjsonobject
wing328
reviewed
May 9, 2025
| @@ -15,6 +15,7 @@ use serde::{Deserialize, Serialize}; | |||
| #[serde(untagged)] | |||
| pub enum DuplicateOneOf { | |||
| Order(Box<models::Order>), | |||
| Order(Box<models::Order>), | |||
There was a problem hiding this comment.
not sure why there are changes to rust samples
can you please file a new PR based on the latest master to see if these changes to rust samples no longer appear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add asJsonObject method to OAIEnum class for cpp-qt-client
Adds the missing method to enum moustache file
@etherealjoy @MartinDelille