Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix hashCode and equals for additionalProperties and generateAliasAsModel #20831

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jpfinne
Copy link
Contributor

@jpfinne jpfinne commented Mar 8, 2025

Fix compilation error for hashcode #20795

Equals also uses additionalProperties if present.

@NilsDammenhayn
The generated code still uses the "new" way of 7.12.0

private Map<String, Object> additionalProperties;

instead of

extends HashMap<String, Object>

This PR only fixes the compilation error for resttemplate, webclient and feign

Microprofile still uses the extends HashMap

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [technical committee]@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@jpfinne jpfinne changed the title [java] Fix hashCode for additionalProperties and generateAliasAsModel [java] Fix hashCode and equals for additionalProperties and generateAliasAsModel Mar 9, 2025
@jpfinne jpfinne marked this pull request as draft March 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant