Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtemodel, projmgr] Recreate constructed files unconditionally (#1147) #1969

Conversation

spcaipers-arm
Copy link
Collaborator

@spcaipers-arm spcaipers-arm commented Feb 18, 2025

Address #1894

From comment:

Without option --update-rte: when constructed files are missing, csolution recreates the files, but issues a warning indicated which file was recreated.
With option --update-rte: the constructed files are updated.

Copy link

github-actions bot commented Feb 18, 2025

Test Results

  7 files   53 suites   5m 8s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 3049afc.

♻️ This comment has been updated with latest results.

@brondani brondani merged commit b5277bf into Open-CMSIS-Pack:main Feb 18, 2025
83 of 84 checks passed
@brondani brondani deleted the outbound/rtemodel-rte-constructed-files branch February 18, 2025 08:47
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.48%. Comparing base (d55a79e) to head (3049afc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 44.44% 0 Missing and 5 partials ⚠️
tools/projmgr/src/ProjMgr.cpp 80.00% 0 Missing and 1 partial ⚠️
...ols/projmgr/test/src/ProjMgrGeneratorUnitTests.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1969   +/-   ##
=======================================
  Coverage   65.48%   65.48%           
=======================================
  Files         173      173           
  Lines       35148    35151    +3     
  Branches    20402    20405    +3     
=======================================
+ Hits        23015    23017    +2     
  Misses       7905     7905           
- Partials     4228     4229    +1     
Flag Coverage Δ
buildmgr-cov 73.94% <ø> (ø)
packchk-cov 68.36% <ø> (ø)
projmgr-cov 81.84% <53.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgr.cpp 81.91% <80.00%> (+0.02%) ⬆️
...ols/projmgr/test/src/ProjMgrGeneratorUnitTests.cpp 79.06% <0.00%> (ø)
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.85% <44.44%> (-0.02%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants