Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packchk] Report warning when deprecated attribute attr="copy" is used in <file> element #1371 (#1143) #1967

Merged

Conversation

spcaipers-arm
Copy link
Collaborator

…d in <file> element Open-CMSIS-Pack#1371 (Open-CMSIS-Pack#1143)

* [packchk] Report warning when deprecated attribute attr="copy" is used in <file> element Open-CMSIS-Pack#1371
Copy link

Test Results

  6 files   12 suites   8s ⏱️
 43 tests  43 ✅ 0 💤 0 ❌
129 runs  129 ✅ 0 💤 0 ❌

Results for commit 1275e0f.

@edriouk edriouk merged commit b93c61a into Open-CMSIS-Pack:main Feb 17, 2025
27 checks passed
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.49%. Comparing base (edb794c) to head (1275e0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../packchk/test/integtests/src/PackChkIntegTests.cpp 68.75% 1 Missing and 4 partials ⚠️
tools/packchk/src/CheckFiles.cpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
+ Coverage   65.48%   65.49%   +0.01%     
==========================================
  Files         173      173              
  Lines       35133    35161      +28     
  Branches    20398    20412      +14     
==========================================
+ Hits        23006    23028      +22     
- Misses       7903     7904       +1     
- Partials     4224     4229       +5     
Flag Coverage Δ
packchk-cov 68.48% <78.57%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/include/CheckFiles.h 100.00% <ø> (ø)
tools/packchk/src/CheckFiles.cpp 70.15% <91.66%> (+0.59%) ⬆️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 69.24% <68.75%> (-0.02%) ⬇️

@grasci-arm grasci-arm deleted the outbound/attrCopyDeprecated_1371 branch February 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants