Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packchk] Issue a warning for description attributes and elements that exceed the recommended limit of 128 (US ASCII) characters #1324 (#1141) #1965

Merged

Conversation

spcaipers-arm
Copy link
Collaborator

…t exceed the recommended limit of 128 (US ASCII) characters Open-CMSIS-Pack#1324 (Open-CMSIS-Pack#1141)

* [packchk] Issue a warning for description attributes and elements that exceed the recommended limit of 128 (US ASCII) characters Open-CMSIS-Pack#1324
Copy link

Test Results

  6 files   12 suites   8s ⏱️
 42 tests  42 ✅ 0 💤 0 ❌
126 runs  126 ✅ 0 💤 0 ❌

Results for commit 5c7a6e5.

@edriouk edriouk merged commit edb794c into Open-CMSIS-Pack:main Feb 17, 2025
27 checks passed
@edriouk edriouk deleted the outbound/description128chars_1324 branch February 17, 2025 13:49
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.48%. Comparing base (3779afa) to head (5c7a6e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../packchk/test/integtests/src/PackChkIntegTests.cpp 78.26% 1 Missing and 4 partials ⚠️
tools/packchk/src/CheckFiles.cpp 81.25% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
+ Coverage   65.46%   65.48%   +0.01%     
==========================================
  Files         173      173              
  Lines       35094    35133      +39     
  Branches    20380    20398      +18     
==========================================
+ Hits        22975    23006      +31     
- Misses       7901     7903       +2     
- Partials     4218     4224       +6     
Flag Coverage Δ
packchk-cov 68.40% <79.48%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/include/CheckFiles.h 100.00% <ø> (ø)
tools/packchk/src/CheckFiles.cpp 69.56% <81.25%> (+0.44%) ⬆️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 69.25% <78.26%> (+0.34%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants