Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packchk] Validate overview attribute of <description> element is a reference to a markdown file contained in the pack that exists #1682 (#1134) #1962

Merged

Conversation

spcaipers-arm
Copy link
Collaborator

…eference to a markdown file contained in the pack that exists Open-CMSIS-Pack#1682 (Open-CMSIS-Pack#1134)

* [packchk] Validate overview attribute of <description> element is a reference to a markdown file contained in the pack that exists Open-CMSIS-Pack#1682

* Test MD file (from middleware) has errors, so shrinked.

* foxed md file
Copy link

github-actions bot commented Feb 12, 2025

Test Results

  6 files   12 suites   9s ⏱️
 37 tests  37 ✅ 0 💤 0 ❌
111 runs  111 ✅ 0 💤 0 ❌

Results for commit 327f41b.

♻️ This comment has been updated with latest results.

@edriouk edriouk merged commit c27c469 into Open-CMSIS-Pack:main Feb 13, 2025
28 of 29 checks passed
@edriouk edriouk deleted the outbound/overviewDescription_1682 branch February 13, 2025 04:11
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (b7d9059) to head (327f41b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../packchk/test/integtests/src/PackChkIntegTests.cpp 56.25% 2 Missing and 5 partials ⚠️
tools/packchk/src/ValidateSyntax.cpp 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
- Coverage   65.23%   65.23%   -0.01%     
==========================================
  Files         173      173              
  Lines       34970    34992      +22     
  Branches    20306    20318      +12     
==========================================
+ Hits        22813    22826      +13     
- Misses       7961     7964       +3     
- Partials     4196     4202       +6     
Flag Coverage Δ
packchk-cov 66.06% <68.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/src/CheckFiles.cpp 66.25% <100.00%> (+0.33%) ⬆️
tools/packchk/src/ValidateSyntax.cpp 64.52% <77.77%> (+0.11%) ⬆️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 68.24% <56.25%> (-0.38%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants