Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackChk should not report .cc as invalid C++ extension (#1121) #1950

Merged

Conversation

spcaipers-arm
Copy link
Collaborator

  • PackChk should not report .cc as invalid C++ extension: SDCMSIS-1306
  • Added test
  • Added Destroy() to ErrLog class

…ck#1121)

* PackChk should not report .cc as invalid C++ extension: SDCMSIS-1306
* Added test
* Added Destroy() to ErrLog class
Copy link

github-actions bot commented Feb 6, 2025

Test Results

  7 files   53 suites   5m 36s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit c45f4e0.

♻️ This comment has been updated with latest results.

edriouk
edriouk previously approved these changes Feb 13, 2025
@edriouk edriouk merged commit 331b229 into Open-CMSIS-Pack:main Feb 13, 2025
60 of 61 checks passed
@edriouk edriouk deleted the outbound/notReportCC_SDCMSIS-1306 branch February 13, 2025 10:33
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (2d97e20) to head (c45f4e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../packchk/test/integtests/src/PackChkIntegTests.cpp 71.05% 2 Missing and 9 partials ⚠️
tools/packchk/src/CheckFiles.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1950   +/-   ##
=======================================
  Coverage   65.42%   65.42%           
=======================================
  Files         173      173           
  Lines       35039    35054   +15     
  Branches    20352    20357    +5     
=======================================
+ Hits        22923    22934   +11     
+ Misses       7908     7906    -2     
- Partials     4208     4214    +6     
Flag Coverage Δ
buildmgr-cov 73.94% <ø> (ø)
packchk-cov 67.95% <69.23%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/packchk/src/CheckFiles.cpp 67.73% <0.00%> (+0.49%) ⬆️
.../packchk/test/integtests/src/PackChkIntegTests.cpp 68.80% <71.05%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants