Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Decrease pack letter case inconsistency severity #1932

Conversation

spcaipers-arm
Copy link
Collaborator

@spcaipers-arm spcaipers-arm commented Jan 24, 2025

Copy link

github-actions bot commented Jan 24, 2025

Test Results

  7 files   53 suites   5m 29s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit d257eeb.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit a523e67 into Open-CMSIS-Pack:main Jan 24, 2025
100 of 101 checks passed
@brondani brondani deleted the outbound/projmgr-pack-case-consistency-warning branch January 24, 2025 12:58
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (fb51ddc) to head (d257eeb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   65.17%   65.16%   -0.01%     
==========================================
  Files         173      173              
  Lines       34848    34850       +2     
  Branches    20227    20230       +3     
==========================================
- Hits        22711    22709       -2     
- Misses       7959     7963       +4     
  Partials     4178     4178              
Flag Coverage Δ
buildmgr-cov 73.94% <ø> (ø)
packchk-cov 65.65% <ø> (ø)
packgen-cov 77.87% <ø> (ø)
projmgr-cov 81.87% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.86% <0.00%> (-0.08%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants