Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for issue #1722 #1849

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Update for issue #1722 #1849

merged 5 commits into from
Nov 18, 2024

Conversation

KeilChris
Copy link
Contributor

@KeilChris KeilChris commented Nov 13, 2024

Documentation clean-up and ensuring packchk tool documentation is visible for the end user.

Copy link

github-actions bot commented Nov 13, 2024

Test Results

    3 files     18 suites   8m 53s ⏱️
  371 tests   371 ✅ 0 💤 0 ❌
1 113 runs  1 113 ✅ 0 💤 0 ❌

Results for commit a673639.

♻️ This comment has been updated with latest results.

@jkrech jkrech self-requested a review November 13, 2024 15:54
jkrech
jkrech previously approved these changes Nov 14, 2024
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check wether you want to consider my comment

@KeilChris
Copy link
Contributor Author

I have incorporated your feedback.

jkrech
jkrech previously approved these changes Nov 18, 2024
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 244fd16 into Open-CMSIS-Pack:main Nov 18, 2024
32 of 33 checks passed
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.91%. Comparing base (dc432f5) to head (a673639).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1849      +/-   ##
==========================================
- Coverage   64.91%   64.91%   -0.01%     
==========================================
  Files         163      163              
  Lines       34452    34449       -3     
  Branches    19971    19968       -3     
==========================================
- Hits        22365    22363       -2     
- Misses       7955     7957       +2     
+ Partials     4132     4129       -3     
Flag Coverage Δ
projmgr-cov 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants