buildmgr: Patch CLANG.cmake to be compatible with LLVM 19 #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LLVM 19 the order of the target triple got swapped. I.e., none-unknown-eabi is not accepted anymore instead unknown-none-eabi is required. By dropping the unknown entirely the reduced target triple is accepted by all major versions 17, 18, and 19 by defaulting to vendor unknown.
Test Results 7 files 53 suites 4m 7s ⏱️ Results for commit eb969f0. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1807 +/- ##
=======================================
Coverage 64.24% 64.24%
=======================================
Files 163 163
Lines 32128 32128
Branches 19636 19636
=======================================
Hits 20641 20641
- Misses 7571 7574 +3
+ Partials 3916 3913 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LLVM 19 the order of the target triple got swapped. I.e., none-unknown-eabi is not accepted anymore instead unknown-none-eabi is required. By dropping the unknown entirely the reduced target triple is accepted by all major versions 17, 18, and 19 by defaulting to vendor unknown.
See llvm/llvm-project#89582