Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csolution] --update-rte has two functions - treat them separately #1894

Open
ReinhardKeil opened this issue Dec 10, 2024 · 2 comments
Open
Assignees
Labels
discussion Indicates an issue being in discussion documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Dec 10, 2024

The Problem To Be Solved

update-rte performs two functions:

  • it generates constructed-files (RTE_Components.h, Pre_Include_Global.h, etc.)
  • it copies configuration files to the RTE folder

I believe these two features should be split. Reasons:

  • When configuration files are forgotten, also the user settings for components are lost. Just copy the original files from packs may therefore result in errors.
  • constructed-files are not user modifiable, they can be regenerated when missing without introducing problems.

The issue becomes apparent when using uv2csolution and folder names are changing due to CMake restrictions (no - in folder names).

@ReinhardKeil ReinhardKeil added enhancement New feature or request discussion Indicates an issue being in discussion labels Dec 10, 2024
@jkrech jkrech moved this to Todo in CMSIS-Toolbox 2.8.0 Dec 17, 2024
@jkrech
Copy link
Member

jkrech commented Jan 27, 2025

Is it acceptable to update constructed-files unconditionally (independently of --update-rte). A file will be written/updated only in case of differences between the files on disk and the newly generated files.

The config files are only being touched if --update-rte is active.

@ReinhardKeil
Copy link
Collaborator Author

Suggest to implement the following behavior regarding constructed files (RTE_Components.h, Pre_Include_Global.h, etc.).

Without option --update-rte: when constructed files are missing, csolution recreates the files, but issues a warning indicated which file was recreated.

With option --update-rte: the constructed files are updated.

@ReinhardKeil ReinhardKeil moved this to Backlog in CMSIS-Toolbox 2.9.0 Jan 27, 2025
@jkrech jkrech moved this to Todo in CMSIS-Toolbox 2.8.0 Jan 28, 2025
@jkrech jkrech added the documentation Improvements or additions to documentation label Feb 4, 2025
@jkrech jkrech changed the title --update-rte has two functions [csolution] --update-rte has two functions - treat them separately Feb 4, 2025
@brondani brondani moved this from Todo to In Progress in CMSIS-Toolbox 2.8.0 Feb 17, 2025
@brondani brondani moved this from In Progress to Done in CMSIS-Toolbox 2.8.0 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Indicates an issue being in discussion documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants