Skip to content

Conversation

@JonatanAntoni
Copy link
Member

@JonatanAntoni JonatanAntoni commented Jan 26, 2026

This is required since adding support for plain numbers and booleans in ARM-software/vscode-cmsis-csolution#383

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, understood this is necessary to allow both numbers in strings and as numbers.

I just realized I missed to review and approve: #66 😕
It probably makes sense to rebase that PR and extend the documentation with details about number handling.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, only realized now that there is more numbers that need to be treated like this.
UPDATE: In particular for the J-Link template, more number-strings go into the serverParameters.

@JonatanAntoni
Copy link
Member Author

Apologies, only realized now that there is more numbers that need to be treated like this. UPDATE: In particular for the J-Link template, more number-strings go into the serverParameters.

In serverParameters I don't see any issues during my tests. The array is rendered as an array-of-strings at a whole, so no conversion happens.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for clarifying!

We don't have that case yet, so no action... I am just curious: Would we already today be able to generate an array of numbers?

@JonatanAntoni JonatanAntoni merged commit 26e3170 into main Jan 26, 2026
2 checks passed
@JonatanAntoni JonatanAntoni deleted the number-as-quoted-string branch January 26, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants