Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New GH issue template to capture new requirements #289

Merged
merged 5 commits into from
Feb 17, 2025
Merged

New GH issue template to capture new requirements #289

merged 5 commits into from
Feb 17, 2025

Conversation

soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Feb 13, 2025 •
edited by jkrech
Loading

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@soumeh01 soumeh01 requested a review from jkrech February 13, 2025 16:29
jkrech
jkrech reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

.github/ISSUE_TEMPLATE/requirement.yaml Outdated Show resolved Hide resolved
@soumeh01 soumeh01 requested a review from jkrech February 17, 2025 09:18
jkrech
jkrech reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a simple check-box over a drop down.

@soumeh01 soumeh01 requested a review from jkrech February 17, 2025 10:25
jkrech
jkrech approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumeh01 soumeh01 merged commit 12a929a into main Feb 17, 2025
1 check passed
@soumeh01 soumeh01 deleted the issue_template branch February 17, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrech jkrech jkrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soumeh01 @jkrech