Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incomplete renaming from hidden to private #333

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix incomplete renaming from hidden to private #333

merged 1 commit into from
Oct 25, 2024

Conversation

jkrech
Copy link
Member

@jkrech jkrech commented Oct 25, 2024

No description provided.

@jkrech jkrech requested a review from KeilChris October 25, 2024 05:38
@jkrech
Copy link
Member Author

jkrech commented Oct 25, 2024

Small documentation fix. I propose not to update the version and dates.

@jkrech jkrech linked an issue Oct 25, 2024 that may be closed by this pull request
File Scope Attribute documentation makes reference to non-existent scope #332
Closed
KeilChris
KeilChris approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@KeilChris KeilChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agreed not to update.

@KeilChris KeilChris merged commit 86e26a4 into main Oct 25, 2024
1 check passed
@KeilChris KeilChris deleted the replace-hidden-with-private branch October 25, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeilChris KeilChris KeilChris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Scope Attribute documentation makes reference to non-existent scope
2 participants
@jkrech @KeilChris