Skip to content

Require semantic release tags #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suguanYang merged 1 commit into from
Jun 30, 2026
Merged

Require semantic release tags #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/build-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ env:
jobs:
build-and-publish:
runs-on: ubuntu-latest
if: >-
${{ github.event_name != 'release' ||
startsWith(github.event.release.tag_name, 'v') ||
startsWith(github.event.release.tag_name, 'oss-v') }}
permissions:
contents: read

Expand All @@ -50,6 +46,18 @@ jobs:
ecr_repo_name: knowhere-worker

steps:
- name: Validate semantic release tag
if: ${{ github.event_name == 'release' }}
shell: bash
run: |
release_tag="${{ github.event.release.tag_name }}"
semver_pattern='^v(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-[0-9A-Za-z.-]+)?$'

if [[ ! "$release_tag" =~ $semver_pattern ]]; then
echo "::error::Knowhere API releases must use semantic version tags like v1.0.1. Date-based tags such as 2026.06.18.1 or v2026.06.18.1 are not supported."
exit 1
fi

- name: Checkout code
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -340,9 +348,7 @@ jobs:
needs: deploy
if: >-
${{ github.event_name == 'release' &&
github.event.action == 'published' &&
(startsWith(github.event.release.tag_name, 'v') ||
startsWith(github.event.release.tag_name, 'oss-v')) }}
github.event.action == 'published' }}
permissions:
contents: write
steps:
Expand Down
Loading