Fix CodeQL comments for document pagination#186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CodeQL review comments surfaced on #185 before merging main into staging.\n\nChanges:\n- Replace implicit string concatenation in the chart asset probe report text.\n- Remove empty except bodies by using missing_ok/ignore_errors or debug logging.\n- Remove a dead budget assignment after refund.\n- Replace overload ellipsis statement bodies with pass bodies.\n\nVerification:\n- make lint\n- make typecheck\n- BILLING_ENABLED=true uv run pytest apps/api/tests/contract/test_billing_contract.py -q\n- git diff --check\n\nNote: running the full PR-CI pytest command locally without BILLING_ENABLED=true produced only billing-route 404 failures because local env disables billing routes. The same billing contract tests pass with BILLING_ENABLED=true.