Skip to content

fix: Update README.md#70

Closed
RainierMM wants to merge 1 commit intoOneSignal:mainfrom
RainierMM:rai-patch
Closed

fix: Update README.md#70
RainierMM wants to merge 1 commit intoOneSignal:mainfrom
RainierMM:rai-patch

Conversation

@RainierMM
Copy link
Copy Markdown

Description

  • A few changes to constant names in the README

Details

  • notification constant is declared twice

Motivation

  • Avoid problems by declaring constants with the same name.

Testing

-N/A

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@sherwinski sherwinski closed this Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants