Skip to content

Commit 33ac788

Browse files
rgomezpjkasten2
authored andcommitted
Added parseVersionString to Utils| moved Utils to shared dir| type fixes
1 parent 32826b5 commit 33ac788

File tree

19 files changed

+39
-30
lines changed

19 files changed

+39
-30
lines changed

src/Event.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Environment from './Environment';
22
import SdkEnvironment from './managers/SdkEnvironment';
33
import { WindowEnvironmentKind } from './models/WindowEnvironmentKind';
44
import Log from './libraries/Log';
5-
import Utils from "./utils/Utils";
5+
import Utils from "./context/shared/utils/Utils";
66

77

88
const SILENT_EVENTS = [

src/OneSignalApiBase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Environment from './Environment';
22
import SdkEnvironment from './managers/SdkEnvironment';
3-
import { Utils } from "./utils/Utils";
3+
import { Utils } from "./context/shared/utils/Utils";
44
import { OneSignalApiError, OneSignalApiErrorKind } from './errors/OneSignalApiError';
55

66
type Headers = any[] & {[key: string]: any};

src/OneSignalApiSW.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ServerAppConfig } from "./models/AppConfig";
22
import { OneSignalApiBase } from "./OneSignalApiBase";
33
import { SubscriptionStateKind } from "./models/SubscriptionStateKind";
44
import Log from "./libraries/Log";
5-
import { Utils } from "./utils/Utils";
5+
import { Utils } from "./context/shared/utils/Utils";
66

77
export class OneSignalApiSW {
88
static async downloadServerAppConfig(appId: string): Promise<ServerAppConfig> {

src/OneSignalApiShared.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { OneSignalApiErrorKind, OneSignalApiError } from './errors/OneSignalApiE
44
import { EmailProfile } from './models/EmailProfile';
55
import { EmailDeviceRecord } from './models/EmailDeviceRecord';
66
import OneSignalApiBase from "./OneSignalApiBase";
7-
import Utils from "./utils/Utils";
7+
import Utils from "./context/shared/utils/Utils";
88

99
export default class OneSignalApiShared {
1010
static getPlayer(appId: string, playerId: string) {

src/Postmam.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import Environment from './Environment';
44
import SdkEnvironment from './managers/SdkEnvironment';
55
import Emitter from './libraries/Emitter';
66
import Log from './libraries/Log';
7-
import { Utils } from "./utils/Utils";
7+
import { Utils } from "./context/shared/utils/Utils";
88
import { OneSignalUtils } from "./utils/OneSignalUtils";
99

1010
/**

src/context/browser/helpers/EnvironmentInfoHelper.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { EnvironmentInfo } from '../models/EnvironmentInfo';
33
import { Browser } from '../models/Browser';
44
import { OneSignalUtils } from '../../../utils/OneSignalUtils';
55
import { isMacOSSafariInIframe } from '../utils/BrowserSupportsPush';
6+
import Utils from '../../shared/utils/Utils';
67

78
/**
89
* EnvironmentInfoHelper is used to save page ("browser") context environment information to
@@ -42,8 +43,8 @@ export class EnvironmentInfoHelper {
4243
return isMacOSSafariInIframe();
4344
}
4445

45-
private static getBrowserVersion(): string|number {
46-
return bowser.version;
46+
private static getBrowserVersion(): number {
47+
return Utils.parseVersionString(bowser.version);
4748
}
4849

4950
private static isHttps(): boolean {

src/context/browser/models/EnvironmentInfo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Browser } from './Browser';
33
// for runtime environment info
44
export interface EnvironmentInfo {
55
browserType: Browser;
6-
browserVersion: string|number;
6+
browserVersion: number;
77
isHttps: boolean;
88
isUsingSubscriptionWorkaround: boolean;
99
isBrowserAndSupportsServiceWorkers: boolean;

src/utils/Utils.ts renamed to src/context/shared/utils/Utils.ts

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import TimeoutError from '../errors/TimeoutError';
1+
import TimeoutError from '../../../errors/TimeoutError';
22

33
interface IndexOfAble {
44
indexOf(match:string): number;
@@ -119,15 +119,12 @@ export class Utils {
119119
}
120120

121121
/**
122-
* Checks if a version is number is greater than or equal (AKA at least) to a specific compare
123-
* to version.
124-
* Limited to only checking for major and minor version values, patch versions are ignored
125-
* @param toCheck - Version we want to check
126-
* @param compareTo - Version we want to be at or higher
127-
* @returns {string} - Returns true if toCheck >= compareTo
122+
* Returns trimmed version number
123+
* e.g: "10.01.30" becomes "10.01"
124+
* @param version - version number we want to check
128125
*/
129-
public static isVersionAtLeast(toCheck: string | number, compareTo: number): boolean {
130-
const osVersionParts = toCheck.toString().split(".");
126+
public static parseVersionString(version: string | number): number {
127+
const osVersionParts = version.toString().split(".");
131128
const majorVersion = Utils.padStart(osVersionParts[0], 2, "0");
132129
let minorVersion: string;
133130
if (osVersionParts[1]) {
@@ -137,8 +134,19 @@ export class Utils {
137134
minorVersion = "00";
138135
}
139136

140-
const majorAndMinor = Number(`${majorVersion}.${minorVersion}`);
141-
return majorAndMinor >= compareTo;
137+
return Number(`${majorVersion}.${minorVersion}`);
138+
}
139+
140+
/**
141+
* Checks if a version is number is greater than or equal (AKA at least) to a specific compare
142+
* to version.
143+
* Limited to only checking for major and minor version values, patch versions are ignored
144+
* @param toCheck - Version we want to check
145+
* @param compareTo - Version we want to be at or higher
146+
* @returns {string} - Returns true if toCheck >= compareTo
147+
*/
148+
public static isVersionAtLeast(toCheck: string | number, compareTo: number): boolean {
149+
return this.parseVersionString(toCheck) >= compareTo;
142150
}
143151

144152
public static enforceAppId(appId: string | undefined | null): void {

src/helpers/ConfigHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { WindowEnvironmentKind } from "../models/WindowEnvironmentKind";
55
import { SdkInitError, SdkInitErrorKind } from "../errors/SdkInitError";
66
import SdkEnvironment from "../managers/SdkEnvironment";
77
import OneSignalUtils from "../utils/OneSignalUtils";
8-
import Utils from "../utils/Utils";
8+
import Utils from "../context/shared/utils/Utils";
99
import MainHelper from './MainHelper';
1010

1111
export enum IntegrationConfigurationKind {

src/helpers/MainHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { SubscriptionStateKind } from '../models/SubscriptionStateKind';
99
import { NotificationPermission } from "../models/NotificationPermission";
1010
import { OneSignalUtils } from "../utils/OneSignalUtils";
1111
import { PermissionUtils } from "../utils/PermissionUtils";
12-
import { Utils } from "../utils/Utils";
12+
import { Utils } from "../context/shared/utils/Utils";
1313

1414
export default class MainHelper {
1515

0 commit comments

Comments
 (0)