trailing spaces, refactored requiresUserInteraction to use returns

Author: rgomezp

src/context/browser/helpers/EnvironmentInfoHelper.ts

@@ -38,7 +38,7 @@ export class EnvironmentInfoHelper {
         if (typeof window.safari !== "undefined") {
             return true;
         }
-    
+
         return isMacOSSafariInIframe();
     }
 
@@ -53,25 +53,23 @@ export class EnvironmentInfoHelper {
     private static isUsingSubscriptionWorkaround(): boolean {
         return OneSignalUtils.isUsingSubscriptionWorkaround();
     }
-    
+
     private static supportsServiceWorkers(): boolean {
-        return (navigator && 'serviceWorker' in navigator);
+        return (window.navigator && 'serviceWorker' in window.navigator);
     }
 
     private static requiresUserInteraction(): boolean {
-        let requiresUserInteraction = false;
-
         // Firefox 72+ requires user-interaction
         if (this.getBrowser() === "firefox" && this.getBrowserVersion() >= 72) {
-            requiresUserInteraction = true;
+            return true;
         }
 
         // Safari 12.1+ requires user-interaction
         if (this.getBrowser() === "safari" && this.getBrowserVersion() >= 12.1) {
-            requiresUserInteraction = true;
+            return true;
         }
 
-        return requiresUserInteraction;
+        return false;
     }
 
     private static getOsVersion(): string|number {

src/context/browser/models/Browser.ts

@@ -5,4 +5,4 @@ export enum Browser {
     Opera = "opera",
     Edge = "edge",
     Other = "other"
-}
+}

src/context/browser/models/EnvironmentInfo.ts

@@ -8,5 +8,5 @@ export interface EnvironmentInfo {
     isUsingSubscriptionWorkaround: boolean;
     isBrowserAndSupportsServiceWorkers: boolean;
     requiresUserInteraction: boolean;
-    osVersion: string|number; 
+    osVersion: string|number;
 }

test/support/sdk/TestEnvironment.ts

@@ -307,7 +307,7 @@ export class TestEnvironment {
 
   static overrideEnvironmentInfo(envInfo: Partial<EnvironmentInfo> = {}) {
     global.OneSignal.environmentInfo = { ...global.OneSignal.environmentInfo, ...envInfo };
-  } 
+  }
 
   // This allows detailed error printing of test that fails due to missing network mock or other reasons.
   static addUnhandledRejectionHandler() {

test/unit/prompts/CustomLink.ts

@@ -291,7 +291,6 @@ test('customlink: subscribe: clicked: unsubscribed -> subscribed. https. never s
 
 test('customlink: subscribe: clicked: unsubscribed -> subscribed. http. never subscribed.', async t => {
   TestEnvironment.overrideEnvironmentInfo({requiresUserInteraction: false});
-  
   sandbox.stub(OneSignal, 'privateIsPushNotificationsEnabled').returns(false);
   sandbox.stub(OneSignal, 'setSubscription').resolves();
   const registerSpy = sandbox.stub(OneSignal, 'registerForPushNotifications').resolves();