Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Tighten up analytics, and make it easier to use. #404

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

aaronbrethorst
Copy link
Member

  • Replace raw strings in analytics categories with named string constants.

- Replace raw strings in analytics categories with named string constants.
@bbodenmiller
Copy link
Contributor

👍

Would like your comments at OneBusAway/onebusaway#5 (comment).

Would also like your help implementing customDimensionForIndex (index 3) for Show Experimental Regions. I can't seem to find the locations where the experimental setting is read/set. Code for the other custom dimensions is at https://github.com/OneBusAway/onebusaway-iphone/blob/develop/models/dao/OBAModelDAOUserPreferencesImpl.m#L211-L247.

aaronbrethorst added a commit that referenced this pull request Mar 26, 2015
Tighten up analytics, and make it easier to use.
@aaronbrethorst aaronbrethorst merged commit 46efb55 into OneBusAway:develop Mar 26, 2015
@aaronbrethorst aaronbrethorst deleted the more-analytics branch March 26, 2015 07:12
@aaronbrethorst
Copy link
Member Author

@bbodenmiller Thanks, Ben. I'll take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants