This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
Improve Google Analytics #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@bbodenmiller Still interested in this PR? |
|
Yes but I'm without a development environment right now. Hope to get that addressed in the next week. |
|
@bbodenmiller any updates? |
|
@aaronbrethorst currently stuck on #259 (comment). Would like to get that fixed but if no one has any ideas I'll try to get around it so I can work on this PR. |
|
It looks like this PR would fix #376 that we noticed on iOS when testing OBA Android analytics. |
* old implementation recorded set event many more times than it actually occurred * new implementation records only when user selects region * if region changes automatically on startup that is recorded in a separate already existing event Conflicts: view_controllers/OBARegionListViewController.m
improves accuracy of app settings analytics as before Google Analytics would store events to be sent during the next session but if the next session did not occur on the same day Google Analytics would throw out the events.
|
@aaronbrethorst ready for review. This improves iOS analytics but does not address the comments in OneBusAway/onebusaway#5 which are still ongoing and I will address in a seperate PR. |
|
Looks good! |
aaronbrethorst
added a commit
that referenced
this pull request
Mar 9, 2015
Improve Google Analytics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest Google Analytics SDK.
Improve region selection analytics:
occurred
separate already existing event
Move app settings analytics to appDidBecomeActive: