Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Updated slf4j version #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated slf4j version #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09a8055
updating slf4j dependency
carabalb Nov 20, 2014
c39b746
Adding exception detail to help troubleshoot failed bundle builds
carabalb Nov 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.5.6</version>
<version>1.7.5</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>1.5.6</version>
<version>1.7.5</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/org/onebusaway/csv_entities/CsvEntityReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,13 @@
import org.onebusaway.csv_entities.schema.DefaultEntitySchemaFactory;
import org.onebusaway.csv_entities.schema.EntitySchema;
import org.onebusaway.csv_entities.schema.EntitySchemaFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class CsvEntityReader {

private static Logger _log = LoggerFactory.getLogger(CsvEntityReader.class);

public static final String KEY_CONTEXT = CsvEntityReader.class.getName()
+ ".context";

Expand Down Expand Up @@ -158,6 +162,7 @@ public void readEntities(Class<?> entityClass, Reader reader)
lineNumber++;
}
} catch (Exception ex) {
_log.error("csv parse exception:", ex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious... was the throw exception not ultimately logged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had some issues in the past where debugging gtfs of questionable quality has been tough based on the log messages provided. I can't remember the particular case in this instance, so I'll remove the statement and resubmit.

throw new CsvEntityIOException(entityClass, schema.getFilename(),
lineNumber, ex);
} finally {
Expand Down